This repository was archived by the owner on Dec 11, 2023. It is now read-only.
EAFP when reading schunk and use ujson if available#346
Open
bordingj wants to merge 1 commit intoBlosc:masterfrom
Open
EAFP when reading schunk and use ujson if available#346bordingj wants to merge 1 commit intoBlosc:masterfrom
bordingj wants to merge 1 commit intoBlosc:masterfrom
Conversation
bordingj
changed the title
Member
|
Looks good to me. Any performance hints on how much this PR can accelerate things? Could you add some estimates to the |
Author
|
In my benchmarks read-speed is ~2% faster |
Member
|
Ok, so 2% is not really significant, although your modifications are not too intrusive, so I am still open to accept this PR. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#318
#319