Skip to content

Introduce placeholder express methods#20

Open
maxparkergene wants to merge 5 commits intodevelopfrom
feature/cls-placeholder-express
Open

Introduce placeholder express methods#20
maxparkergene wants to merge 5 commits intodevelopfrom
feature/cls-placeholder-express

Conversation

@maxparkergene
Copy link
Copy Markdown
Contributor

Previously there was a large CSL score because all of the Adyen Express methods were being lazy loaded and only showing after the network request had finished.

The BlueFinch Checkout has had an update allowing for placeholder express methods to be rendered and remain visible until the lazy loading of the full Express methods.

This update introduces these placeholders and then switches them out after we have fully rendered the express methods.

Previously there was a large CSL score because all of the Adyen Express methods were being lazy loaded and only showing after the network request had finished.

The BlueFinch Checkout has had an update allowing for placeholder express methods to be rendered and remain visible until the lazy loading of the full Express methods.

This update introduces these placeholders and then switches them out after we have fully rendered the express methods.
@maxparkergene maxparkergene requested a review from Nehaenko May 20, 2025 14:48
$this->adyenPaymentMethodManagement->getPaymentMethods($quoteId),
true
) : [];
$result[self::PAYMENT_METHODS_KEY] = $paymentMethods;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxparkergene This will currently fire after all section data loads, but if adyen express payments is enabled we're already doing this request once. This will help reduce load on adyen and keep this lean

Screenshot 2025-05-23 at 14 27 14

We need to handle two cases

  • Adyen express enabled
    • we need to check storeConfigPaths to see if express is active and enabled
    • if it is, then we terminate this plugin because we dont want to duplicate api requests
    • we also need a new plugin or extension, after the adyen express functionality to grab that payload and use it for our purposes. so that we dont run the same request twice
  • Adyen express not enabled
    • use this implementation, as its very similar to the adyen express method.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @convenient,

Thanks for the feedback and I have added the checks as you've suggested to only run the Adyen API request if the express module is not enabled. If it is there is a separate plugin that will take the data and use it as we are expecting in BlueFinch checkout.

If the Adyen Express module is enabled then they will have already gathered the payment methods to be added into the customer data.

Added a check to see if any of the configuration for Adyen Express is enabled and if so we will not run the lookup ourselves but instead use a plugin to take the data that already exists and use it for our purposes.
@maxparkergene maxparkergene requested a review from convenient June 18, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants