Open
Conversation
Previously there was a large CSL score because all of the Adyen Express methods were being lazy loaded and only showing after the network request had finished. The BlueFinch Checkout has had an update allowing for placeholder express methods to be rendered and remain visible until the lazy loading of the full Express methods. This update introduces these placeholders and then switches them out after we have fully rendered the express methods.
Nehaenko
approved these changes
May 20, 2025
convenient
reviewed
May 23, 2025
Plugin/CustomerData/Cart.php
Outdated
| $this->adyenPaymentMethodManagement->getPaymentMethods($quoteId), | ||
| true | ||
| ) : []; | ||
| $result[self::PAYMENT_METHODS_KEY] = $paymentMethods; |
Contributor
There was a problem hiding this comment.
@maxparkergene This will currently fire after all section data loads, but if adyen express payments is enabled we're already doing this request once. This will help reduce load on adyen and keep this lean
We need to handle two cases
- Adyen express enabled
- we need to check storeConfigPaths to see if express is active and enabled
- if it is, then we terminate this plugin because we dont want to duplicate api requests
- we also need a new plugin or extension, after the adyen express functionality to grab that payload and use it for our purposes. so that we dont run the same request twice
- Adyen express not enabled
- use this implementation, as its very similar to the adyen express method.
Contributor
Author
There was a problem hiding this comment.
Hi @convenient,
Thanks for the feedback and I have added the checks as you've suggested to only run the Adyen API request if the express module is not enabled. If it is there is a separate plugin that will take the data and use it as we are expecting in BlueFinch checkout.
If the Adyen Express module is enabled then they will have already gathered the payment methods to be added into the customer data. Added a check to see if any of the configuration for Adyen Express is enabled and if so we will not run the lookup ourselves but instead use a plugin to take the data that already exists and use it for our purposes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Previously there was a large CSL score because all of the Adyen Express methods were being lazy loaded and only showing after the network request had finished.
The BlueFinch Checkout has had an update allowing for placeholder express methods to be rendered and remain visible until the lazy loading of the full Express methods.
This update introduces these placeholders and then switches them out after we have fully rendered the express methods.