Claude/loving albattani eolo8l - #153
Merged
Merged
Conversation
Two factory fixes for launch readiness:
1. Token marketing was permanently locked. cw20-base disables
UpdateMarketing/UploadLogo forever when `marketing` is None at
instantiation, and the factory never set it — every creator token
would have been un-brandable (no logo, description, or project URL)
with no retrofit possible. The factory now instantiates each CW20
with the pool creator as marketing admin (project/description/logo
start empty for the creator to fill in).
2. The registry was not enumerable. PoolByAddress existed but nothing
answered "what pools exist?" — explorers needed an event indexer
just for discovery. New `Pools { start_after, limit }` query pages
POOLS_BY_ID ascending (default 30, max 100 per page), returning
pool_id, pool_addr, pool_token_info, and pool_kind per entry.
Tests: create-path assertion that the CW20 instantiate submessage
carries the creator as marketing admin; pagination test covering
ordering, resume-after, end-of-data, and limit clamping. Both
documented in the README query reference.
https://claude.ai/code/session_01PBHdD9Wpt5rB8eUCWQHzVw
The LastCommited variant's canonical wire name carries an on-chain
typo ("last_commited"). A serde alias now also accepts
"last_committed" so new integrations don't have to ship the typo;
renaming outright would break every deployed client. Covered by a
test deserializing both spellings.
https://claude.ai/code/session_01PBHdD9Wpt5rB8eUCWQHzVw
New Section 7 in FRONTEND_MIGRATION: why creator-token pairs route through bluechip, the router's atomicity and 3-hop cap, the no-per-hop-slippage model (size minimum_receive from simulate_multi_hop), and working code for both entry paths (native execute_multi_hop with funds; CW20 send with the embedded hook). Later sections renumbered 7-15 -> 8-16 with the TOC and cross-references updated, plus three router rows in troubleshooting. Mirrors the same section shipped in the block explorer's integration guide page so the two guides stay in lockstep. https://claude.ai/code/session_01PBHdD9Wpt5rB8eUCWQHzVw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.