Skip to content
This repository was archived by the owner on Jun 4, 2020. It is now read-only.

Cache the version data#12

Open
griest024 wants to merge 1 commit intoBob123a1:masterfrom
griest024:version-cache
Open

Cache the version data#12
griest024 wants to merge 1 commit intoBob123a1:masterfrom
griest024:version-cache

Conversation

@griest024
Copy link
Copy Markdown

Maintains a disk and memory cache of the version list. This should dramatically speed up loading of large queues and when scanning for games since it eliminates most network requests.

It also includes a preloaded cache so it works out of the box and user doesn't have to build the cache themselves.

@griest024
Copy link
Copy Markdown
Author

Hide the whitespace changes if its not already

Maintains a disk and memory cache of the version list.
This should dramatically speed up loading of large queues and when scanning for games since it eliminates most network requests.
It also includes a preloaded cache so it works out of the box and user doesn't have to build the cache themselves.
@Bob123a1
Copy link
Copy Markdown
Owner

This is similar to what I decided to implement after I saw your work! Thanks for the great idea. See here:

def update_ver_list(self):
But I believe there's always room for improvements, I'll see what else can be done to further improve it!

@griest024
Copy link
Copy Markdown
Author

Well from testing, this seems to be much faster than whatever was there before. Can you confirm that? It might just be me...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants