Fix dynamic lora path too.#68
Draft
Ph0rk0z wants to merge 3 commits into
Draft
Conversation
added 3 commits
June 2, 2026 14:06
Revert "Allow dynamic lora to compile" This reverts commit f080eba.
Contributor
Author
|
Here's the benchmarks again. Disable Dynamic Vram! Klein 4 lora stochastic - Reroll Klein 4 lora stochastic - Reroll Compiled Klein 4 Lora Dynamic - Reroll Klein 4 Lora Dynamic - Reroll Compiled (this path still busted?) Klein 4 Lora Dynamic - Reroll Compiled (post clauderization) Needs: export TORCHINDUCTOR_EMULATE_PRECISION_CASTS=1 Enable dynamic Vram! Stochastic lora - Reroll Stochastic Lora - Compiled (thanks rattus) Stochastic Lora - Compiled (dynamic disabled at node) It's not very effective. I guess now to find out why the KJ nodes can't disable dynamic vram from a switch. |
Contributor
Author
|
Here's the wf btw. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's slower but it works and now allows compiling with dynamic vram off.