Skip to content

fix(Typography): Make typography small and bold variants work again#102

Merged
tchock merged 2 commits into
mainfrom
fix/typography-variants
May 23, 2025
Merged

fix(Typography): Make typography small and bold variants work again#102
tchock merged 2 commits into
mainfrom
fix/typography-variants

Conversation

@tchock
Copy link
Copy Markdown
Member

@tchock tchock commented May 23, 2025

No description provided.

@github-actions github-actions Bot added the bug Something isn't working label May 23, 2025
@github-actions
Copy link
Copy Markdown

size-limit report 📦

Path Size
Common JS 22.01 KB (+0.04% 🔺)
Button direct import (Common JS) 4.99 KB (+0.24% 🔺)
Button Treeshaking 6.7 KB (+0.81% 🔺)
Input Treeshaking 3.9 KB (+0.18% 🔺)
Tooltip Treeshaking 6.43 KB (-0.35% 🔽)
ES Module 19.07 KB (+0.26% 🔺)

@tchock tchock requested a review from Copilot May 23, 2025 13:23
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issues with typography variants by updating theme variable generation and adjusting typography styling. Key changes include:

  • Adding a guard for undefined values in the internal theme variable generation logic.
  • Updating typography variant resolution to use props correctly.
  • Adjusting snapshot outputs for typography components to reflect the small and bold variants.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

File Description
src/theme/createThemeVars.ts Added guard for undefined values in internalThemeVars.
src/theme/PabloThemeProvider.tsx Revised theme variable definitions with improved conditional logic.
src/Typography/Typography.tsx Updated typography variant resolution to access theme via props.
Various snapshot files (Typography, TextArea, NativeSelect, Input) Updated snapshots to reflect new typography CSS adjustments.
Comments suppressed due to low confidence (1)

src/Typography/snapshots/Typography.spec.tsx.snap:44

  • [nitpick] The snapshot now includes a direct 'font-weight: 500' declaration following a variable-based font-weight. Verify that this duplication is intended and that the override aligns with the design system.
font-weight: 500;

Comment thread src/theme/PabloThemeProvider.tsx
@tchock tchock merged commit 95b172e into main May 23, 2025
4 checks passed
@tchock tchock deleted the fix/typography-variants branch May 23, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants