fix(Typography): Make typography small and bold variants work again#102
Merged
Conversation
size-limit report 📦
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues with typography variants by updating theme variable generation and adjusting typography styling. Key changes include:
- Adding a guard for undefined values in the internal theme variable generation logic.
- Updating typography variant resolution to use props correctly.
- Adjusting snapshot outputs for typography components to reflect the small and bold variants.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/theme/createThemeVars.ts | Added guard for undefined values in internalThemeVars. |
| src/theme/PabloThemeProvider.tsx | Revised theme variable definitions with improved conditional logic. |
| src/Typography/Typography.tsx | Updated typography variant resolution to access theme via props. |
| Various snapshot files (Typography, TextArea, NativeSelect, Input) | Updated snapshots to reflect new typography CSS adjustments. |
Comments suppressed due to low confidence (1)
src/Typography/snapshots/Typography.spec.tsx.snap:44
- [nitpick] The snapshot now includes a direct 'font-weight: 500' declaration following a variable-based font-weight. Verify that this duplication is intended and that the override aligns with the design system.
font-weight: 500;
JohannesMerz
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.