Skip to content

fix: render bugs #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tchock merged 2 commits into from
Jul 18, 2025
Merged

fix: render bugs #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57cbeb1
fix: render bugs
tchock Jul 11, 2025
3fc542a
Update snapshots
tchock Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Button/Button.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,3 +162,11 @@ WithCustomStyles.args = {
`,
},
};

export const Test = () => (
<Flex>
<div>hi</div>
<Button>to big!</Button>
<Box height={100}>I am a tall box!</Box>
</Flex>
);
8 changes: 4 additions & 4 deletions src/Input/Input.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export default {

const ControlledInput = ({ value: valueInitial, ...props }: Omit<InputProps, 'onChange'>) => {
const [value, setValue] = useState(valueInitial);
return <Input value={value} mb={4} {...props} onChange={setValue} />;
return <Input value={value} {...props} onChange={setValue} />;
};

const baseStory = (args) => <ControlledInput {...args} />;
Expand Down Expand Up @@ -63,13 +63,13 @@ Error.args = {

export const MultipleInputs = () => (
<Box>
<Box mb={5}>
<Box>
<ControlledInput label="first name" />
</Box>
<Box mb={5}>
<Box>
<ControlledInput label="last name" />
</Box>
<Box mb={5}>
<Box>
<ControlledInput label="credit card no." infoText="optional" />
</Box>
</Box>
Expand Down
4 changes: 4 additions & 0 deletions src/Input/__snapshots__/Input.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
exports[`Render without value 1`] = `
.emotion-0 {
box-sizing: border-box;
margin-bottom: clamp(1rem, 0.8571428571428572rem + 0.7142857142857143vw, 1.5rem);
}

.emotion-1 {
Expand Down Expand Up @@ -67,6 +68,7 @@ exports[`Render without value 1`] = `
exports[`Show error when an error message is given 1`] = `
.emotion-0 {
box-sizing: border-box;
margin-bottom: clamp(1rem, 0.8571428571428572rem + 0.7142857142857143vw, 1.5rem);
}

.emotion-1 {
Expand Down Expand Up @@ -168,6 +170,7 @@ exports[`Show error when an error message is given 1`] = `
exports[`Show infotext when available 1`] = `
.emotion-0 {
box-sizing: border-box;
margin-bottom: clamp(1rem, 0.8571428571428572rem + 0.7142857142857143vw, 1.5rem);
}

.emotion-1 {
Expand Down Expand Up @@ -263,6 +266,7 @@ exports[`Show infotext when available 1`] = `
exports[`Show label when available 1`] = `
.emotion-0 {
box-sizing: border-box;
margin-bottom: clamp(1rem, 0.8571428571428572rem + 0.7142857142857143vw, 1.5rem);
}

.emotion-1 {
Expand Down
4 changes: 4 additions & 0 deletions src/NativeSelect/__snapshots__/NativeSelect.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
exports[`Render without value 1`] = `
.emotion-0 {
box-sizing: border-box;
margin-bottom: clamp(1rem, 0.8571428571428572rem + 0.7142857142857143vw, 1.5rem);
}

.emotion-1 {
Expand Down Expand Up @@ -111,6 +112,7 @@ exports[`Render without value 1`] = `
exports[`Show error when an error message is given 1`] = `
.emotion-0 {
box-sizing: border-box;
margin-bottom: clamp(1rem, 0.8571428571428572rem + 0.7142857142857143vw, 1.5rem);
}

.emotion-1 {
Expand Down Expand Up @@ -256,6 +258,7 @@ exports[`Show error when an error message is given 1`] = `
exports[`Show infotext when available 1`] = `
.emotion-0 {
box-sizing: border-box;
margin-bottom: clamp(1rem, 0.8571428571428572rem + 0.7142857142857143vw, 1.5rem);
}

.emotion-1 {
Expand Down Expand Up @@ -395,6 +398,7 @@ exports[`Show infotext when available 1`] = `
exports[`Show label when available 1`] = `
.emotion-0 {
box-sizing: border-box;
margin-bottom: clamp(1rem, 0.8571428571428572rem + 0.7142857142857143vw, 1.5rem);
}

.emotion-1 {
Expand Down
1 change: 1 addition & 0 deletions src/SidebarNav/SidebarNavItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export interface SidebarNavItemProps extends ButtonBaseProps {
const SidebarNavItemWrapper = styled.li<SidebarNavItemProps>`
${buttonBaseStyles}
display: flex;
cursor: pointer;
margin: ${getComponentStyle('sidebarNav.item.marginY')} 0;
${getCustomStyles('sidebar.item.styles', 'root')}

Expand Down
3 changes: 3 additions & 0 deletions src/SidebarNav/__snapshots__/SidebarNav.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ exports[`Render multiple nav items 1`] = `
display: -webkit-flex;
display: -ms-flexbox;
display: flex;
cursor: pointer;
margin: clamp(0.5rem, 0.4285714285714286rem + 0.35714285714285715vw, 0.75rem) 0;
}

Expand Down Expand Up @@ -99,6 +100,7 @@ exports[`Render multiple nav items 1`] = `
display: -webkit-flex;
display: -ms-flexbox;
display: flex;
cursor: pointer;
margin: clamp(0.5rem, 0.4285714285714286rem + 0.35714285714285715vw, 0.75rem) 0;
background-color: var(--pbl-theme-colors-brand-lightest);
}
Expand Down Expand Up @@ -196,6 +198,7 @@ exports[`Render one nav item 1`] = `
display: -webkit-flex;
display: -ms-flexbox;
display: flex;
cursor: pointer;
margin: clamp(0.5rem, 0.4285714285714286rem + 0.35714285714285715vw, 0.75rem) 0;
background-color: var(--pbl-theme-colors-brand-lightest);
}
Expand Down
Loading
Loading