Skip to content

Linked list resubmit#17

Open
kurtrm wants to merge 7 commits intomasterfrom
linked-list-resubmit
Open

Linked list resubmit#17
kurtrm wants to merge 7 commits intomasterfrom
linked-list-resubmit

Conversation

@kurtrm
Copy link
Copy Markdown
Collaborator

@kurtrm kurtrm commented Jun 29, 2017

Addressed the following comments:
[X] The push method should be able to store any kind of val, not raise an error if I try to input 'True'.

[X] There should be a method called size, that returns the size of the list. You have only implemented the len method that does this. Just make a size method that returns the same thing as the len.

[X] Your remove method is not working correctly. It is should raise a ValueError if it can't find the node it wants to remove. Also the logic in the while loop is incorrect, more importantly the assignment says that the remove method takes a node, not a value of a node as an arg.

[X] Your display method return '(:, I, f, a)' when it should return "(':', 'I', 'f', 'a')"

As with the previous resubmits, tox and coverage are focused on the linked list data structure alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants