Open
Conversation
…he priority queue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed the following comments:
[X] The push method should be able to store any kind of val, not raise an error if I try to input 'True'.
[X] There should be a method called size, that returns the size of the list. You have only implemented the len method that does this. Just make a size method that returns the same thing as the len.
[X] Your remove method is not working correctly. It is should raise a ValueError if it can't find the node it wants to remove. Also the logic in the while loop is incorrect, more importantly the assignment says that the remove method takes a node, not a value of a node as an arg.
[X] Your display method return '(:, I, f, a)' when it should return "(':', 'I', 'f', 'a')"
As with the previous resubmits, tox and coverage are focused on the linked list data structure alone.