switch to deterministic wrapper creation using seed#641
Open
mschneider wants to merge 5 commits into
Open
Conversation
brittcyr
reviewed
Jul 8, 2026
| connection, | ||
| trader, | ||
| ); | ||
| if (!userWrapper) { |
Contributor
There was a problem hiding this comment.
also check if we are in a squadsx situation and have a need to make a new wrapper since we cannot sign
Contributor
Author
There was a problem hiding this comment.
i dont think squadsx ever signed anything in this case, the error message mentioned that there's no wrapper found for this particular owner
Contributor
Author
There was a problem hiding this comment.
i also checked their tx history. seems to be all ok
mschneider
force-pushed
the
max/wrapper-seed
branch
from
4b5eb38 to
5dccd33
Compare
brittcyr
approved these changes
Jul 9, 2026
| // (both when a new wrapper is created and when an existing wrapper only needs | ||
| // a seat claimed) so callers can build follow-on instructions without having | ||
| // to inspect the setup instructions themselves. | ||
| wrapperState: PublicKey | null; |
Contributor
There was a problem hiding this comment.
Make the var name clear it is an address or pubkey not the state itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.