Rename project_eigenvectors to rotate_to_physical_auxiliary_basis with improved documentation
#19
+69
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed
project_eigenvectorsindyson/util/linalg.pyto better reflect its purpose: constructing a biorthonormal basis spanning physical (Dyson orbitals) and auxiliary (null space) spaces, then rotating eigenvectors into that basis.Changes
Function rename:
project_eigenvectors→rotate_to_physical_auxiliary_basisrotate_subspace,set_subspace)Enhanced docstring:
Updated call sites:
spectral.py,exact.py,davidson.py,util/__init__.pyExample
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.