DM gradient for non-hermitain case #3
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obackhouse
reviewed
Feb 20, 2024
| @@ -225,8 +225,13 @@ def gradient(self, x, fock=None, out=None): | |||
| h1 = -np.dot(c[gf.nphys :, gf_occ.naux :].conj().T, c[gf.nphys :, : gf_occ.naux]) | |||
Collaborator
There was a problem hiding this comment.
we probably also need some control over hermiticity here
Collaborator
|
before merging this we should probably make sure that the behaviour is sound regarding complex eigenvalues -- should I also don't think that states are necessarily sorted at any point, so the filling might be in the wrong order even just by the real parts -- I guess we should write some unit tests with complex states. |
This reverts commit d60e1b7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.