Conversation
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull request overview
This PR bumps the version of the BootstrapBlazor.Html2Pdf component from 10.0.2 to 10.0.3 and restructures PuppeteerSharp package references to use target framework-specific versions. The changes enable the component to use different PuppeteerSharp versions based on the .NET framework being targeted, with older frameworks (net6.0, net7.0) using version 20.2.6 and newer frameworks (net8.0, net9.0, net10.0) using version 21.0.1.
Changes:
- Version bumped from 10.0.2 to 10.0.3
- Refactored PuppeteerSharp package references from a single unconditional reference to framework-specific conditional ItemGroups
- Applied framework-specific version targeting: PuppeteerSharp 20.2.6 for net6.0/net7.0, and 21.0.1 for net8.0/net9.0/net10.0
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <ItemGroup Condition="'$(TargetFramework)' == 'net8.0'"> | ||
| <PackageReference Include="PuppeteerSharp" Version="21.0.1" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="'$(TargetFramework)' == 'net9.0'"> | ||
| <PackageReference Include="PuppeteerSharp" Version="21.0.1" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="'$(TargetFramework)' == 'net10.0'"> | ||
| <PackageReference Include="PuppeteerSharp" Version="21.0.1" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
The conditional ItemGroups for net8.0, net9.0, and net10.0 all reference the same PuppeteerSharp version (21.0.1). This could be simplified using a condition like "'$(TargetFramework)' == 'net8.0' or '$(TargetFramework)' == 'net9.0' or '$(TargetFramework)' == 'net10.0'" to reduce duplication. However, this pattern is consistent with other components in the repository (FileViewer and Html2Pdf.Select), so maintaining consistency with existing codebase patterns may be preferred over optimization.
Link issues
fixes #922
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bump the BootstrapBlazor.Html2Pdf component project to a newer version of its Html2Pdf dependency.
Bug Fixes:
Enhancements: