Conversation
upgrade embed-pdf 2.6.1
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @ArgoZhang, your pull request is larger than the review limit of 150000 diff characters
There was a problem hiding this comment.
Pull request overview
This PR bumps BootstrapBlazor.EmbedPDF to 10.0.1 and refreshes the shipped EmbedPDF viewer JS assets, while improving enum XML docs with bilingual (zh/en) descriptions.
Changes:
- Bump NuGet package version to 10.0.1
- Refresh/minify/rename EmbedPDF JS asset entrypoints in
wwwroot - Update enum XML documentation to include Chinese + English text
Reviewed changes
Copilot reviewed 8 out of 15 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/BootstrapBlazor.EmbedPDF/wwwroot/readme.txt | Adds a local note pointing to upstream viewer releases. |
| src/components/BootstrapBlazor.EmbedPDF/wwwroot/embedpdf.js | Updates re-export to point at the new hashed bundle file. |
| src/components/BootstrapBlazor.EmbedPDF/wwwroot/direct-engine-m4-HnUa2.js | Removes an old hashed direct-engine bundle. |
| src/components/BootstrapBlazor.EmbedPDF/wwwroot/browser-awZxztMA-DP8ttsSz.js | Removes an old hashed browser bundle. |
| src/components/BootstrapBlazor.EmbedPDF/wwwroot/browser-BISJ9naB-b_RbRYIt.js | Adds a new hashed browser bundle referencing the new core bundle. |
| src/components/BootstrapBlazor.EmbedPDF/EmbedPDFTheme.cs | Improves enum docs with bilingual <para> blocks. |
| src/components/BootstrapBlazor.EmbedPDF/EmbedPDFTabBarMode.cs | Improves enum docs with bilingual <para> blocks. |
| src/components/BootstrapBlazor.EmbedPDF/EmbedPDFScrollStrategy.cs | Improves enum docs with bilingual <para> blocks. |
| src/components/BootstrapBlazor.EmbedPDF/BootstrapBlazor.EmbedPDF.csproj | Bumps version and excludes wwwroot/readme.txt from static-web-assets content. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /// <para lang="zh">主题枚举</para> | ||
| /// <para lang="en">Theme enumeration</para> |
There was a problem hiding this comment.
XML documentation localization should use the standard "xml:lang" attribute rather than "lang" (which many doc tools ignore). Consider updating to xml:lang (e.g., / ) for better tooling support.
| /// <para lang="zh">标签模式枚举</para> | ||
| /// <para lang="en">Tab bar mode enumeration</para> |
There was a problem hiding this comment.
Same as above: use "xml:lang" instead of "lang" on XML doc elements to ensure localization metadata is recognized by documentation generators.
| /// <para lang="zh">滚动方向枚举</para> | ||
| /// <para lang="en">Scroll strategy enumeration</para> |
There was a problem hiding this comment.
Same as above: prefer "xml:lang" for localized XML documentation (many tools do not interpret a plain "lang" attribute).
| <Content Remove="wwwroot\readme.txt" /> | ||
| <None Include="wwwroot\readme.txt" /> |
There was a problem hiding this comment.
MSBuild generally tolerates backslashes, but using forward slashes in item paths is more consistently cross-platform and avoids edge cases in tooling. Consider changing to "wwwroot/readme.txt" for both entries.
| <Content Remove="wwwroot\readme.txt" /> | |
| <None Include="wwwroot\readme.txt" /> | |
| <Content Remove="wwwroot/readme.txt" /> | |
| <None Include="wwwroot/readme.txt" /> |
| @@ -0,0 +1 @@ | |||
| https://github.com/embedpdf/embed-pdf-viewer/releases?wt.mc_id=DT-MVP-5004174 下载 snippet-dist 包 | |||
There was a problem hiding this comment.
The URL includes a tracking/campaign query parameter (wt.mc_id). If this file is shared within the repo/package, it's better to avoid embedding tracking identifiers; consider linking to the clean releases URL without the query string.
| https://github.com/embedpdf/embed-pdf-viewer/releases?wt.mc_id=DT-MVP-5004174 下载 snippet-dist 包 | |
| https://github.com/embedpdf/embed-pdf-viewer/releases 下载 snippet-dist 包 |
Link issues
fixes #932
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge