Fix for when prediction breakdown does not contain main label#182
Open
Cyborger1 wants to merge 4 commits intoBot-detector:masterfrom
Open
Fix for when prediction breakdown does not contain main label#182Cyborger1 wants to merge 4 commits intoBot-detector:masterfrom
Cyborger1 wants to merge 4 commits intoBot-detector:masterfrom
Conversation
auto-assign
bot
requested review from
Ferrariic,
ThorntonMatthewD and
extreme4all
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the API returns a breakdown with at least one element and that breakdown does not contain the primary label, it is added before being sent over to the plugin. Ideally this should not happen, this is more of a fallback measure.
Also some random changes to using
isEmpty()in there, I'm not sure why I didn't use those before.