github action for Add code comment to encode.ts explaining the strict…#159
Open
yunus-dev-codecrafter wants to merge 3 commits intoBoxkit-Labs:mainfrom
Open
github action for Add code comment to encode.ts explaining the strict…#159yunus-dev-codecrafter wants to merge 3 commits intoBoxkit-Labs:mainfrom
yunus-dev-codecrafter wants to merge 3 commits intoBoxkit-Labs:mainfrom
Conversation
… bigint-only policy for IDs
Contributor
|
@yunus-dev-codecrafter please fix conflict on your branch |
Contributor
|
@yunus-dev-codecrafter i do not understand this PR, it does not resolve the issue you were been assigned |
Author
|
Closes #124 I added a clear IMPORTANT note explaining that IDs must use If this isn’t followed, it can cause wrong values and incorrect muxed addresses. The note is placed right before the function so future contributors won’t miss it. |
Contributor
|
@yunus-dev-codecrafter Ok, PR reviewed and confirmed, please delete the node modules folder from this PR, it is not needed |
It has been deleted
Author
|
The node module folder has been deleted..
…On Mon, Mar 30, 2026, 3:39 PM Lewechi ***@***.***> wrote:
*codeZe-us* left a comment (Boxkit-Labs/stellar-address-kit#159)
<#159?email_source=notifications&email_token=BEBDHIC5GNRFHUK54EZPYBL4TKBJPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJVGU2TOMZRHA22M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4155573185>
@yunus-dev-codecrafter <https://github.com/yunus-dev-codecrafter> Ok, PR
reviewed and confirmed, please delete the node modules folder from this PR,
it is not needed
—
Reply to this email directly, view it on GitHub
<#159?email_source=notifications&email_token=BEBDHIC5GNRFHUK54EZPYBL4TKBJPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJVGU2TOMZRHA22M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4155573185>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BEBDHIHGJZZ7QRPHWDTTK4D4TKBJPAVCNFSM6AAAAACXAX5HI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCNJVGU3TGMJYGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
codeZe-us
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #124
… bigint-only policy for IDs
The comment:
Clearly marks the requirement with an "IMPORTANT:" prefix
Explains the technical reason why bigint is necessary (JavaScript numbers can't safely represent integers beyond 2^53 - 1)
States the consequence of not following this rule (precision loss and incorrect muxed addresses)
Is positioned prominently right before the function definition for maximum visibility to future contributors