feat: define RoutingSource string literal union#160
Merged
codeZe-us merged 1 commit intoBoxkit-Labs:mainfrom Mar 26, 2026
Merged
feat: define RoutingSource string literal union#160codeZe-us merged 1 commit intoBoxkit-Labs:mainfrom
codeZe-us merged 1 commit intoBoxkit-Labs:mainfrom
Conversation
|
@codewithzubair07 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
codeZe-us
approved these changes
Mar 26, 2026
Contributor
codeZe-us
left a comment
codeZe-us
left a comment
There was a problem hiding this comment.
@codewithzubair07 this is okay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced a reusable RoutingSource string literal union to improve type safety in the routing module.
Changes
Added RoutingSource type:
'muxed' | 'memo' | 'none'
Replaced inline string union in RoutingResult.routingSource with the new reusable type
Why this change
Previously, the routing source type was defined inline, which could lead to duplication and inconsistent usage.
Defining a dedicated type ensures:
Stronger type safety
Better maintainability
Consistent usage across the routing module
Impact
No breaking changes
Purely improves type structure and code clarity
Testing
Project builds successfully with pnpm build
No runtime behavior affected
Closes #127