Fix/contract sender warning#163
Merged
codeZe-us merged 3 commits intoBoxkit-Labs:mainfrom Mar 26, 2026
Merged
Conversation
|
@codewithzubair07 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
codewithzubair07
force-pushed
the
fix/contract-sender-warning
branch
from
3582810 to
d9d54ef
Compare
codeZe-us
approved these changes
Mar 26, 2026
Contributor
codeZe-us
left a comment
codeZe-us
left a comment
There was a problem hiding this comment.
@codewithzubair07 This is okay, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements contract-sender warning logic in extractRouting for C-address inputs.
Changes
Detects contract (C) addresses
Returns default routing state:
destinationBaseAccount: null
routingId: null
routingSource: "none"
Adds warning:
code: CONTRACT_SENDER_DETECTED
severity: warn
Notes
Avoids treating contract addresses as errors
Aligns with existing Warning type constraints
Keeps behavior consistent with existing routing logic
Result
C-address inputs now return a safe fallback state with a proper warning instead of failing silentl
close #132