Merged
Conversation
|
@quickweb-stack Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
Done, #170 |
codeZe-us
approved these changes
Mar 26, 2026
Contributor
codeZe-us
left a comment
codeZe-us
left a comment
There was a problem hiding this comment.
@quickweb-stack this is okay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #128
Implemented the routing-side Warning discriminated union in [types.ts] and updated routing code to consume that local type in [extract.ts] and [memo.ts]. The union now gives typed variants for normalization warnings, invalid destinations, unsupported memo types, and the remaining simple warning codes, which makes switch/case handling exhaustive and avoids raw stringly-typed warning shapes in the routing pipeline.
I also verified the changed imports and reviewed the diff. I attempted npm run build in packages/core-ts, but verification is currently blocked by an existing dependency problem in tsup: Cannot find module 'resolve-from', so I couldn’t complete a full type/build check yet.