fix(core-dart): detect C address sourceAccount and emit CONTRACT_SEND…#182
Merged
codeZe-us merged 2 commits intoBoxkit-Labs:mainfrom Mar 28, 2026
Merged
Conversation
…ER_DETECTED warning
|
@Manuelshub Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
codeZe-us
approved these changes
Mar 28, 2026
Contributor
codeZe-us
left a comment
There was a problem hiding this comment.
@Manuelshub This is okay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #74
fix(core-dart): detect C address
sourceAccountand emitCONTRACT_SENDER_DETECTEDwarningProblem
extractRoutingin the Dart implementation ignored thesourceAccountfieldon
RoutingInputentirely. If a contract address (C...) was supplied as thetransaction source, it passed through silently with no warning — leaving
downstream pipeline consumers with no signal that the routing context was
invalid.
The Go implementation already handled this correctly by checking
sourceAccountat the top of
ExtractRoutingand returning early with aCONTRACT_SENDER_DETECTEDwarning. The Dart implementation was out of parity.Solution
Added a
sourceAccountcheck at the entry point ofextractRouting, mirroringthe Go behavior exactly. If
sourceAccountis non-null, non-empty, and parsesas a C address, the function returns early with:
routingSource: nonewarnings: [CONTRACT_SENDER_DETECTED](severity:info)All other routing logic is bypassed, consistent with the spec.
Files Changed
packages/core-dart/lib/src/routing/extract.dartTesting
All routing and spec vector tests pass.