fix: add comprehensive JSDoc to extractRouting decision engine#197
Open
Yusufolosun wants to merge 1 commit intoBoxkit-Labs:mainfrom
Open
fix: add comprehensive JSDoc to extractRouting decision engine#197Yusufolosun wants to merge 1 commit intoBoxkit-Labs:mainfrom
Yusufolosun wants to merge 1 commit intoBoxkit-Labs:mainfrom
Conversation
Contributor
|
@Yusufolosun please fix conflict |
Contributor
|
@Yusufolosun please i do not understand this PR, it holds alot of irrelevant code that are outside the task you were been assigned to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #186
Summary
Adds maintainer-grade JSDoc for
extractRoutingso IDE hover clearly explains routing behavior and decision precedence.Root Cause
extractRoutinglacked function-level JSDoc, leaving behavior across M-address routing, G-address memo routing, and non-routable memo states undocumented at the call site.Fix
Added a single comprehensive JSDoc block above
extractRoutinginextract.tscovering:No runtime logic was changed.
Testing