Skip to content

feat: enforce no-restricted-syntax for BigInt safety in core-ts#201

Merged
codeZe-us merged 1 commit intoBoxkit-Labs:mainfrom
A5cend-dev:main
Mar 29, 2026
Merged

feat: enforce no-restricted-syntax for BigInt safety in core-ts#201
codeZe-us merged 1 commit intoBoxkit-Labs:mainfrom
A5cend-dev:main

Conversation

@A5cend-dev
Copy link
Copy Markdown
Contributor

@A5cend-dev A5cend-dev commented Mar 29, 2026

Closes #194


#194 Enforce no-restricted-syntax for BigInt Safety

The Issue
needed a way to automatically stop developers from accidentally converting BigInt values to Number in the core-ts package. This is dangerous because JavaScript silently corrupts any number above 2^53-1 when you do that, which can break routing logic without any error.
What you did
You forked the repo and set it up locally on your machine. Since the core-ts package had no ESLint config, you created one from scratch — packages/core-ts/.eslintrc.js. Inside it, you configured a no-restricted-syntax rule that bans Number(), unary +, and parseFloat(), which are the main ways a developer could accidentally coerce a BigInt into a Number.
You also installed @typescript-eslint/parser so ESLint could read the TypeScript files in the package, since it couldn't parse them by default.
You then ran ESLint locally to verify it was working, and it caught a real violation in src/test/extract.test.ts at line 162 — proof that the rule is active and CI will now fail on any unsafe BigInt conversions.
Finally you committed only the .eslintrc.js file and pushed it to your fork, then opened a PR back to the original repo.

@drips-wave
Copy link
Copy Markdown

drips-wave bot commented Mar 29, 2026

@A5cend-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@codeZe-us codeZe-us self-requested a review March 29, 2026 15:01
Copy link
Copy Markdown
Contributor

@codeZe-us codeZe-us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@A5cend-dev approved

@codeZe-us codeZe-us merged commit b8119bb into Boxkit-Labs:main Mar 29, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enforce no-restricted-syntax for BigInt Safety

2 participants