Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves multiple compilation errors and architectural inconsistencies across the core-go package by consolidating core data models and fixing logic gaps in the routing extraction flow. Key improvements include refactoring detect.go to remove duplicate declarations, adding a missing Warnings field to the Address struct, and centralizing RoutingResult and DestinationError into types.go to eliminate naming conflicts. Additionally, it fixes NewRoutingID constructor calls and undefined variable issues in extract.go, while aligning the unit test suite with these structural updates for complete functional coverage. All modules have been verified to pass both go build and the full test suite.