Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns the library's core implementations across TypeScript, Go, and Dart to strictly adhere to the normative specification and official SDK best practices. It refactors the TypeScript decodeMuxed function to directly utilize the official @stellar/stellar-sdk's MuxedAccount.fromAddress method, removing redundant manual bitwise operations while strictly preserving the required BigInt safety bounds to prevent precision loss. Additionally, it resolves a compliance gap in the TypeScript version of extractRouting by ensuring that Contract (C) addresses provided as destinations correctly throw an INVALID_DESTINATION error rather than a generic sender warning, fully mirroring the logic already present in the Dart and Go implementations. All cross-language test suites and validation vectors have been executed and pass flawlessly.