using inline <reified T> to convert querySnapShot to List<T>#2
Open
ch8n wants to merge 2 commits intoBracketCove:masterfrom
Open
using inline <reified T> to convert querySnapShot to List<T>#2ch8n wants to merge 2 commits intoBracketCove:masterfrom
ch8n wants to merge 2 commits intoBracketCove:masterfrom
Conversation
added 2 commits
October 25, 2019 17:39
extension that will help in converting any query snapshot result to list of its pojos
extension that will help in converting any query snapshot result to list of its pojos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi , @BracketCove I saw seeing your code, it's awesome, I see you were using repeating function to resultToList in which only type was varying, In Kotlin you can use to take inline type of the type so dont need to repeat it, you can read more :
https://kotlinlang.org/docs/reference/inline-functions.html
I havent written test for this, but it was tested in my production code, Please do leave a review