Merged
Conversation
Configures stricter linting for both Python and Rust codebases, and fixes the identified issues
Python (Ruff):
- Adds ARG, C90, FURB, PERF, PLE/PLR/PLW, PT,
PTH, RET, RUF, SIM
Rust (Clippy):
- Enable pedantic mode with sensible exceptions
- Add workspace-level lint configuration
Adds additional global allow's for linting of tests, benchmarks.
Owner
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This is a great pull request that significantly improves code quality and consistency by enabling stricter linting rules for both Rust (clippy) and Python (ruff). The changes are extensive and demonstrate a commitment to maintainability, from using more idiomatic language features and improving performance to enhancing documentation and test robustness. The new lint configurations are well-thought-out, with sensible exceptions for scientific and test code. I have one suggestion regarding the scope of some disabled clippy lints to further improve safety.
…ive error docstrings, updates stubs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds rules for strict linting