refactor: migrate custom fields from fixtures to exported customizations#167
Open
engahmed1190 wants to merge 2 commits intodevelopfrom
Open
refactor: migrate custom fields from fixtures to exported customizations#167engahmed1190 wants to merge 2 commits intodevelopfrom
engahmed1190 wants to merge 2 commits intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
custom_field.json) to exported customizations (pos_next/custom/*.json)hooks.pyfixturesKnown Issues — Corrupted / Foreign Fields
Foreign Custom Fields (from other apps — KSA/UAE localization)
item.jsonItem-is_zero_ratedis_system_generated: 1,module: nullitem.jsonItem-is_exemptis_system_generated: 1,module: nullsales_invoice.jsonSales Invoice-company_trnis_system_generated: 1,module: null, fetchescompany.tax_idsales_invoice.jsonSales Invoice-customer_name_in_arabicis_system_generated: 1,module: nullsales_invoice.jsonSales Invoice-ksa_einv_qris_system_generated: 1,module: nullsales_invoice_item.jsonSales Invoice Item-is_zero_ratedis_system_generated: 1,module: nullsales_invoice_item.jsonSales Invoice Item-is_exemptis_system_generated: 1,module: nullpos_profile.jsonPOS Profile-custom_brands_tablemodule: null, referencesPOS Brands Detailchild tableSite-Specific Property Setters (should NOT be exported)
item.json: 7 property_setters (naming_series hidden/options/reqd, item_code hidden/reqd, barcodes hidden, field_order)sales_invoice.json: 14 property_setters (naming_series options, various hidden/print_hide tweaks)sales_invoice_item.json: 4 property_setters (barcode hidden, discount_account, target_warehouse)pos_profile.json: 1 property_setter (field_order)Site-Specific Custom Perms (already handled by
custom_docperm.jsonfixture)item.json: 9 custom_perms (all ERPNext standard roles + POSNext Cashier — duplicated)sales_invoice.json: 3 custom_perms (duplicated fromcustom_docperm.json)pos_profile.json: 3 custom_perms (duplicated fromcustom_docperm.json)Phantom Field Reference (pre-existing bug)
pos_profile.jsonline 163:"insert_after": "posa_default_sales_order"— this field does NOT exist anywhere in the codebaseUnnecessary Files (zero POS Next customizations)
item_barcode.json— only contains a site-specific property_setterpacked_item.json— only contains a site-specific property_setterWhat SHOULD remain (POS Next only,
module: "POS Next")custom_companyposa_pos_opening_shiftposa_is_printedposa_cash_mode_of_paymentposa_allow_deleteposa_block_sale_beyond_available_qtyinsert_after)is_wallet_paymentAction Required
Each custom JSON file needs to be cleaned to contain only fields with
module: "POS Next", remove all foreignproperty_setters, remove duplicatedcustom_perms, and deleteitem_barcode.jsonandpacked_item.jsonentirely.