Bump version to 1.0.4 and add build/AppInspect CI - #12
Merged
Conversation
Published 1.0.3 can't be republished to Splunkbase without a version bump. Also wires a validate.yml CI workflow that builds via .build.sh (pnpm) and gates on local AppInspect, using the SUI build_command mode of Bre77/splunk_nats's reusable workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
1.0.3published, so the recent@splunkreact-ui 5 migration + compat work can't ship as a patch until the version moves past it.package.jsonversionandsrc/main/resources/splunk/default/app.conf([id]+[launcher]stanzas) from1.0.3->1.0.4, kept in sync as this app requires..github/workflows/validate.yml, callingBre77/splunk_nats's reusable_reusable-build-appinspect.ymlin itsbuild_commandmode (./.build.sh, which runspnpm install && pnpm buildand writesbadrcm.splto the repo root).package.jsonpackageManager); Splunk Python 3.9 provisioned for AppInspect.fail_on: errors- verified locally: 0 errors, 0 failures, only pre-existing warnings (missing[shclustering]stanza,check_for_updateson a private app, public IPs in a source map) that don't block a private-app republish.What Changed
package.json:version1.0.3 -> 1.0.4src/main/resources/splunk/default/app.conf:[id]and[launcher]version1.0.3 -> 1.0.4.github/workflows/validate.yml: new build + AppInspect CI on push tomainand on PRsAGENTS.md: added a## Releasesection documenting the two version locations and the new CI workflowTesting
./.build.shrun locally:pnpm install && pnpm buildsucceeds (only non-fatal webpack asset-size warnings), producesbadrcm.splat repo rootsplunk-appinspect inspect badrcm.spl --mode precertrun locally against the built package: 0 errors, 0 failures, 7 pre-existing warnings