Added the is_graduating check - #50
Open
3791xk wants to merge 7 commits into
Open
Conversation
Added checked_graduating everywhere User objects are defined and used, as well as the alembic migration for the column
It would not build otherwise
It was hard to tell which fields had a request already and which didnt, so now they are easier to find
Added UserUpdateGraduationRequest for editing a users graduation details (is_graduating and checked_graduating), as well as the endpoint for it (curently only the user themselves can edit their graduation details). I also replaced UserChangeDetailsRequest with UserChangeMajorRequest since all the other User fields have their own separate requests and it made more sense to remove the generic "details" one, in favor of logical seperation/names
This dialog gets triggered when the user opens the Summary page, for the first time that semester (login redirects to Summary, so its really the first time they login that semester). The is_graduating value is set based on the user response, and checked_graduating is set to true
Went home, rethought my life, decided that the possibility setting every single users checked_graduating boolean value to false when a semester changes could become a problem, and changed checked_graduating to a Semester id instead so that isnt necessary. Updated every place checked_graduating is used. This means the updating computation will only run for active users
Collaborator
Author
|
This fixes issue #45 |
BreadInvasion
previously approved these changes
Aug 3, 2026
BreadInvasion
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added the pop up dialog that asks the user whether or not they're graduating that semester if this hasn't been checked yet in that current semester. A successful user login gets automatically redirected to the Summary page, so that's where the check of whether their
is_graduatingfield is up to date or not happens. Their response gets set in the database in the booleanis_graduatingfield, andchecked_graduatingis set to that currentSemesterid. If thechecked_graduatingfield matches the current semester, then the dialog does not show up.Components:
Userand updated all referenceschecked_graduatingwas a boolean before becoming aSemesterid 244ced2)edit_user_graduation), which uses the also newUserUpdateGraduationRequestSummarypage. If thechecked_graduatingfield is null or not the current semester, the dialog is triggeredSorry these are part of this unrelated PR:
Visual of the dialog:
