refactor: replace submodule with local testing framework#15
Open
RonTuretzky wants to merge 1 commit intoimplement-cicd-specfrom
Open
refactor: replace submodule with local testing framework#15RonTuretzky wants to merge 1 commit intoimplement-cicd-specfrom
RonTuretzky wants to merge 1 commit intoimplement-cicd-specfrom
Conversation
Changes: - Remove foundry-counter submodule and integration-test.yml - Add local test framework in tests/ and scripts/ - Rename workflow titles for clarity: - Foundry CI -> Build & Test - Foundry CI/CD -> CI/CD Pipeline - Deploy -> Deploy & Verify - Detect Changes -> Detect Contract Changes - Post Mainnet -> Post-Deploy Snapshots - Upgrade Safety -> Upgrade Safety Check - Add test.yml workflow to run tests in CI - Update README with new testing approach Testing approach: - Extract testable logic from workflows into scripts/ - Test against fixtures covering success and failure cases - Runs locally (./tests/run-all.sh) and in CI Test coverage: - Compiler config validation (bytecode_hash, cbor_metadata) - Baseline detection (primary path, fallback, missing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/andscripts/test.ymlworkflow to run tests in CIWorkflow Name Changes
Testing Approach
The workflow logic is tested by extracting testable shell functions into standalone scripts, then running them against test fixtures that cover success and failure cases.
Why This Approach?
Running Tests
Test Coverage
test-compiler-config.shbytecode_hashandcbor_metadatavalidationtest-baseline-detection.sh