Open
Conversation
Quartenia
reviewed
Mar 3, 2026
Member
Quartenia
left a comment
There was a problem hiding this comment.
works fine on the Vroom repository, if you want me to also test it in bee it would take a bit longer :)
I am no sure if that's intended but i removed const from a platform file and it was not picked up by the hook, i sent it in dm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds clang-tidy prefixes to
cpp-linter-hooksthrough the following two arguments added to theclang-tidyhook:--clang-tool-prefix: Specifies a prefix for the clang-tidy tool.--prefix-regex: Specifies a regex to use for the previously specified prefixBoth arguments can be called multiple times to make it more useful for projects that require the use of several specific
clang-tidytoolchains.As a safety measure, no more regexes may be defined than prefixes and no more than two more prefixes may be defined than there are regexes.
Reviewer checklist
pre-commit(pip install pre-commit)clang-tidywill give an error forpython -m pre_commit install)pre-commiton all files (python -m pre_commit run --all-files)Note
The arguments are not added to the
clang-formathook since from testing the non-prefixed tool gives the same result as ones with a prefix.Supplement: .pre-commit-config.yaml
Replace 'REPLACE_ME' with the prefix you want to test and 'DB_PATH' with the path that compile_commands.json is in.