GAUD-9365 - Use outline: none instead of only outline-width #6541
Conversation
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
| border-width: 2px; | ||
| outline-style: none; /* Safari */ | ||
| outline-width: 0; | ||
| outline: none; |
There was a problem hiding this comment.
Only checkbox.scss and radio.scss above are broken, but I figured I'd update all the inputs to be consistent. We can either go with what I have here (outline: none;) or keep outline-style: none; and outline-width: 0; and switch radio and checkbox to that.
Any preference? I went with outline: none; because it's shorthand for those and simpler.
| display: inline-block; | ||
| height: ${cssSizes.inputBoxSize}rem; | ||
| margin: 0; | ||
| outline: none; |
There was a problem hiding this comment.
This file wasn't broken, but switching it to match what the others do. I was the one who originally added this fix here for Firefox.
There was a problem hiding this comment.
Updated this to verify it fixes the vdiffs. I'll likely revert this piece before merging and have update-package-lock handle it.
Chrome 144 has changed the behaviour of
outline-width:That's resulting in these vdiffs. I've confirmed that Safari and Firefox are currently broken (and probably have been for quite a while), but we don't run vdiff in those. They don't look as obviously broken as Chrome does now.
Chrome 144+:
Firefox (Currently):
Safari (Currently):
We're not planning to backport this - it'll only affect users of the
coreSASS. And I can't even find a usage in the LMS, because of thereset.cssalso turningoutlineoff.