Skip to content

fix: prevent infinite recursion in server.close()#130

Open
amitksingh1490 wants to merge 1 commit intoBrowserMCP:mainfrom
amitksingh1490:main
Open

fix: prevent infinite recursion in server.close()#130
amitksingh1490 wants to merge 1 commit intoBrowserMCP:mainfrom
amitksingh1490:main

Conversation

@amitksingh1490
Copy link

Store reference to original close method before overriding to prevent stack overflow when closing the server.

Store reference to original close method before overriding to prevent
stack overflow when closing the server.
@SuitDeer
Copy link

SuitDeer commented Nov 30, 2025

@namukang
I have seen the same error in Kilo Code (VS Code Extension):

file:///home/gero/.npm/_npx/6ddf87659f2ad8a4/node_modules/@browsermcp/mcp/dist/index.js:248 server.close = async () => { ^ RangeError: Maximum call stack size exceeded at server.close 
(file:///home/gero/.npm/_npx/6ddf87659f2ad8a4/node_modules/@browsermcp/mcp/dist/index.js:248:18) at server.close 
(file:///home/gero/.npm/_npx/6ddf87659f2ad8a4/node_modules/@browsermcp/mcp/dist/index.js:249:18) at server.close 
(file:///home/gero/.npm/_npx/6ddf87659f2ad8a4/node_modules/@browsermcp/mcp/dist/index.js:249:18) at server.close 
(file:///home/gero/.npm/_npx/6ddf87659f2ad8a4/node_modules/@browsermcp/mcp/dist/index.js:249:18) at server.close 
(file:///home/gero/.npm/_npx/6ddf87659f2ad8a4/node_modules/@browsermcp/mcp/dist/index.js:249:18) at server.close 
(file:///home/gero/.npm/_npx/6ddf87659f2ad8a4/node_modules/@browsermcp/mcp/dist/index.js:249:18) at server.close 
(file:///home/gero/.npm/_npx/6ddf87659f2ad8a4/node_modules/@browsermcp/mcp/dist/index.js:2...(error message truncated)
grafik

After manually applying the fix #130 , the mcp could load without any problem.

Please merge the fix. Without that browserMCP can not work with Kilo Code

@fsjsd
Copy link

fsjsd commented Jan 20, 2026

Just had this error. Please merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants