fix: prevent infinite recursion in server.close()#130
Open
amitksingh1490 wants to merge 1 commit intoBrowserMCP:mainfrom
Open
fix: prevent infinite recursion in server.close()#130amitksingh1490 wants to merge 1 commit intoBrowserMCP:mainfrom
amitksingh1490 wants to merge 1 commit intoBrowserMCP:mainfrom
Conversation
Store reference to original close method before overriding to prevent stack overflow when closing the server.
|
@namukang
After manually applying the fix #130 , the mcp could load without any problem. Please merge the fix. Without that browserMCP can not work with Kilo Code |
|
Just had this error. Please merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Store reference to original close method before overriding to prevent stack overflow when closing the server.