Expose IP address and disconnect event#1674
Open
DRSDavidSoft wants to merge 1 commit intoBrowserSync:masterfrom
Open
Expose IP address and disconnect event#1674DRSDavidSoft wants to merge 1 commit intoBrowserSync:masterfrom
DRSDavidSoft wants to merge 1 commit intoBrowserSync:masterfrom
Conversation
|
Any progress on this? |
Author
|
@shakyShane I would appreciate it if you consider merging this! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to be notified of when someone has connected to my session externally.
Summary
Since
logConnections: trueonly emits a singleBrowser Connected: . . .line, bs has to expose the client's ip address from the socket event.So, I am using the following code to be notified of new connections:
Without exposing
handshake.addressandclient.on("disconnect", { . . . })methods, it's impossible to acquire the client's ip address and thus be notified of such events.Scope
This PR exposes
socket.io's following properties in order to write custom event listeners:handshake.addressclient.on("disconnect", { . . . })Status
Feedback
Would be glad to hear from you!