Use absolute worker path to fix document loading in packaged apps #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
In the packaged release apps there is currently a problem with loading a document - the service worker is failing to initialise:
#48
#36
Analaysis:
In the packaged Electron app the relative path './src/service/worker.js' no longer works. See https://stackoverflow.com/a/71098112
Fix:
The solution is to use the correct absolute path by using
__dirname.Testing:
I have tested and verified this fix with
npm run packageon macOS .(Could someone verify this fix for Windows and Linux packaged apps too?)