Refactor: Extract duplicated patterns into shared utilities by Copilot · Pull Request #54 · Bryan-Roe/Aria

Copilot · 2026-02-17T09:50:44Z

Eliminated ~150 lines of duplicated code across providers, HTTP endpoints, and import patterns by extracting common logic into reusable utilities.

Changes

Provider Response Handling

Extracted OpenAI-compatible streaming/non-streaming response parsing from 3 provider classes into BaseChatProvider helper methods:

class BaseChatProvider:
    @staticmethod
    def _handle_openai_streaming_response(response) -> Generator[str, None, None]:
        """Common handler for OpenAI-style streaming responses"""
        
    @staticmethod
    def _handle_openai_non_streaming_response(response) -> str:
        """Common handler for OpenAI-style non-streaming responses"""

Impact: OpenAIProvider and LMStudioProvider now use shared logic; AzureOpenAIProvider uses it for non-quota cases.

Defensive Import Pattern

Created shared/import_helpers.py to consolidate try/except import blocks with fallbacks:

# Before: 5+ repeated blocks in function_app.py
try:
    from shared.sql_engine import sql_health, engine_stats
except Exception:
    def sql_health(): return {"enabled": False}
    def engine_stats(): return {"enabled": False}

# After: One-liner with fallback factory
sql_funcs = safe_import('shared.sql_engine', 
                       import_names=('sql_health', 'engine_stats'),
                       fallback_factory=create_stub_function)

HTTP Utilities

Created shared/http_utils.py consolidating validation and file serving:

validate_messages() - Message format validation (used in 2+ endpoints)
create_cors_headers() - CORS header generation
serve_static_file() - File serving with error handling

Refactored http_chat/function_app.py and http_chat_web/function_app.py to use shared utilities.

Test Coverage

30 unit tests added covering all utility functions (100% passing).

Additional Refactoring Opportunities

Identified but not implemented:

sys.path manipulation (60+ instances, inconsistent patterns)
Configuration loading (80+ direct os.getenv() calls without validation)

See docs/REFACTORING_SUMMARY.md for details.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

sourcery-ai

Hi @Copilot! 👋

Your private repo does not have access to Sourcery.

Please upgrade to continue using Sourcery ✨

…orts Co-authored-by: Bryan-Roe <74067792+Bryan-Roe@users.noreply.github.com>

Co-authored-by: Bryan-Roe <74067792+Bryan-Roe@users.noreply.github.com>

bryan-roe-bot · 2026-02-17T10:12:37Z

+        resp = self.client.chat.completions.create(
+            model=self.model,
+            messages=messages,
+            temperature=self.temperature,
+            max_tokens=self.max_output_tokens,
+            stream=stream,
+        )


Semgrep identified an issue in your code:
Possibly found usage of AI: OpenAI

To resolve this comment:

🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.

💬 Ignore this finding

Reply with Semgrep commands to ignore this finding.

/fp <comment> for false positive

/ar <comment> for acceptable risk

/other <comment> for all other reasons

Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by detect-openai.

_{You can view more details about this finding in the Semgrep AppSec Platform.}

bryan-roe-bot · 2026-02-17T10:12:38Z

+        resp = self.client.chat.completions.create(
+            model=self.model,
+            messages=messages,
+            temperature=self.temperature,
+            max_tokens=self.max_output_tokens,
+            stream=stream,
+        )


Semgrep identified an issue in your code:
Possibly found usage of AI: OpenAI

To resolve this comment:

🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.

💬 Ignore this finding

Reply with Semgrep commands to ignore this finding.

/fp <comment> for false positive

/ar <comment> for acceptable risk

/other <comment> for all other reasons

Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by detect-openai.

_{You can view more details about this finding in the Semgrep AppSec Platform.}

bryan-roe-bot · 2026-02-17T10:12:39Z

Semgrep found 6 detect-generic-ai-oai findings:

talk-to-ai/src/chat_providers.py
- L108 - Triage
- L110 - Triage
- L110 - Triage
- L124 - Triage
- L126 - Triage
- L126 - Triage

Possibly found usage of AI: OpenAI

Semgrep found 6 return-not-in-function findings:

function_app.py
- L65 - Triage
- L73-77 - Triage
- L74 - Triage
- L75 - Triage
- L76 - Triage
- L77 - Triage

return only makes sense inside a function

bryan-roe-bot · 2026-02-17T10:15:20Z

+        return True, None, None
+
+    provider_lower = provider_choice.lower()
+    valid_providers = {'auto', 'openai', 'azure', 'local', 'lora', 'lmstudio'}


Semgrep identified an issue in your code:
Possibly found usage of AI: OpenAI

To resolve this comment:

🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.

💬 Ignore this finding

Reply with Semgrep commands to ignore this finding.

/fp <comment> for false positive

/ar <comment> for acceptable risk

/other <comment> for all other reasons

Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by detect-generic-ai-oai.

_{You can view more details about this finding in the Semgrep AppSec Platform.}

bryan-roe-bot · 2026-02-17T10:15:21Z

+    """Validate provider choice and model override.
+
+    Args:
+        provider_choice: The requested provider ('auto', 'openai', 'azure', 'local', 'lora')


Semgrep identified an issue in your code:
Possibly found usage of AI: OpenAI

To resolve this comment:

🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.

💬 Ignore this finding

Reply with Semgrep commands to ignore this finding.

/fp <comment> for false positive

/ar <comment> for acceptable risk

/other <comment> for all other reasons

Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by detect-generic-ai-oai.

_{You can view more details about this finding in the Semgrep AppSec Platform.}

sourcery-ai

Hi @Bryan-Roe! 👋

Your private repo does not have access to Sourcery.

Please upgrade to continue using Sourcery ✨

Copilot

Pull request overview

Refactors duplicated provider/HTTP/import patterns into shared utilities, and adds unit tests to lock in behavior.

Changes:

Extracted shared OpenAI-compatible streaming/non-streaming response parsing into BaseChatProvider.
Added shared/import_helpers.py and refactored optional imports in function_app.py to use safe_import().
Added shared/http_utils.py and refactored HTTP endpoints to use shared validation/CORS/static-file serving helpers.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
tests/test_provider_response_handling.py	Adds tests for the new `BaseChatProvider` response helper methods.
tests/test_import_helpers.py	Adds tests for `safe_import()` and `create_stub_function()`.
tests/test_http_utils.py	Adds tests for shared HTTP validation/header/static-file helpers.
talk-to-ai/src/chat_providers.py	Introduces shared response handlers and refactors providers to use them.
shared/import_helpers.py	New module to consolidate defensive import + fallback patterns.
shared/http_utils.py	New module for message/provider validation and static file serving helpers.
http_chat_web/function_app.py	Refactors static file serving to use `serve_static_file()`.
http_chat/function_app.py	Refactors message validation + CORS header creation via shared helpers.
function_app.py	Refactors optional imports to use `safe_import()` utilities.
docs/REFACTORING_SUMMARY.md	Adds documentation summarizing refactor scope and impact.

Copilot · 2026-02-17T10:53:05Z

+def serve_static_file(
+    file_path: Path,
+    mimetype: str,
+    use_cache_headers: bool = False
+) -> Tuple[Optional[str], int, Dict[str, str]]:


use_cache_headers is misleading: when it's True, the function adds no-cache headers via create_no_cache_headers(). This is likely to confuse callers/maintainers and contradicts the intent implied by the name. Rename the parameter to something like disable_cache / no_cache (and update docstring accordingly), or invert the behavior so use_cache_headers=True actually enables cache-friendly headers.

Copilot · 2026-02-17T10:53:05Z

+    Args:
+        file_path: Path to the file to serve
+        mimetype: MIME type for the response (e.g., 'text/html', 'application/javascript')
+        use_cache_headers: Whether to add no-cache headers (default: False for better caching)


use_cache_headers is misleading: when it's True, the function adds no-cache headers via create_no_cache_headers(). This is likely to confuse callers/maintainers and contradicts the intent implied by the name. Rename the parameter to something like disable_cache / no_cache (and update docstring accordingly), or invert the behavior so use_cache_headers=True actually enables cache-friendly headers.

Copilot · 2026-02-17T10:53:05Z

+        headers = {}
+        if use_cache_headers:
+            headers.update(create_no_cache_headers())


use_cache_headers is misleading: when it's True, the function adds no-cache headers via create_no_cache_headers(). This is likely to confuse callers/maintainers and contradicts the intent implied by the name. Rename the parameter to something like disable_cache / no_cache (and update docstring accordingly), or invert the behavior so use_cache_headers=True actually enables cache-friendly headers.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 016f6c9f68

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-17T10:54:44Z

 from datetime import datetime

+# Import defensive import helper
+from shared.import_helpers import safe_import, create_stub_function


Guard import_helpers import to preserve startup fallbacks

This unconditional top-level import introduces a hard dependency on the shared package at module import time. In environments where shared is not on sys.path (the same scenario the surrounding code previously handled with defensive try/except imports), function_app.py now fails to load before any fallback stubs are installed, which can prevent the Functions worker from starting at all.

Useful? React with 👍 / 👎.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Initial plan

19a1c6c

Copilot AI assigned Copilot and Bryan-Roe Feb 17, 2026

sourcery-ai Bot reviewed Feb 17, 2026

View reviewed changes

Copilot started work on behalf of Bryan-Roe February 17, 2026 09:51 View session

Copilot AI and others added 3 commits February 17, 2026 10:01

Refactor: Extract common provider response handling and defensive imp…

db5cfec

…orts Co-authored-by: Bryan-Roe <74067792+Bryan-Roe@users.noreply.github.com>

Refactor: Extract HTTP validation and file serving utilities

b9525dc

Co-authored-by: Bryan-Roe <74067792+Bryan-Roe@users.noreply.github.com>

docs: Add comprehensive refactoring summary

016f6c9

Co-authored-by: Bryan-Roe <74067792+Bryan-Roe@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Refactor duplicated code to improve maintainability~~ Refactor: Extract duplicated patterns into shared utilities Feb 17, 2026

Copilot AI requested a review from Bryan-Roe February 17, 2026 10:09

Copilot finished work on behalf of Bryan-Roe February 17, 2026 10:09

bryan-roe-bot Bot reviewed Feb 17, 2026

View reviewed changes

Bryan-Roe requested review from Copilot and removed request for Bryan-Roe February 17, 2026 10:46

Bryan-Roe marked this pull request as ready for review February 17, 2026 10:46

sourcery-ai Bot reviewed Feb 17, 2026

View reviewed changes

Copilot AI reviewed Feb 17, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Feb 17, 2026

View reviewed changes

github-actions Bot added documentation Improvements or additions to documentation tests azure-functions chat-interface labels Feb 17, 2026

Copilot started reviewing on behalf of Bryan-Roe February 17, 2026 11:05 View session

Bryan-Roe and others added 3 commits February 17, 2026 06:43

Update shared/http_utils.py

da5ced4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update http_chat_web/function_app.py

98a8b54

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update http_chat/function_app.py

d91e15a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update tests/test_provider_response_handling.py

7c4f9c7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Bryan-Roe merged commit 44e2dea into main Feb 17, 2026
6 of 13 checks passed

Bryan-Roe deleted the copilot/refactor-duplicated-code-again branch February 17, 2026 14:44

Uh oh!

Conversation

Copilot AI commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Provider Response Handling

Defensive Import Pattern

HTTP Utilities

Test Coverage

Additional Refactoring Opportunities

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

bryan-roe-bot Bot Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

bryan-roe-bot Bot Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

bryan-roe-bot Bot commented Feb 17, 2026

Uh oh!

bryan-roe-bot Bot Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

bryan-roe-bot Bot Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Feb 17, 2026 •

edited

Loading