Skip to content

style: automated autofixes from CodeQL workflow#631

Merged
Bryan-Roe merged 2 commits into
mainfrom
chore/codeql-autofix-28751339070
Jul 5, 2026
Merged

style: automated autofixes from CodeQL workflow#631
Bryan-Roe merged 2 commits into
mainfrom
chore/codeql-autofix-28751339070

Conversation

@github-actions

@github-actions github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Automated cleanup pushed by the CodeQL Advanced workflow.

Tools applied:

  • ruff check --fix + ruff format (unsafe fixes only enabled when allow_unsafe_fixes=true on scheduled/manual runs)
  • prettier --write
  • eslint --fix (if configured in the repository)
  • clang-format -i --style=file (when C/C++ files are present)

Triggered by: push on refs/heads/main (run #28751339070).

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @github-actions[bot], you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@Bryan-Roe Bryan-Roe requested a review from Copilot July 5, 2026 19:05

Copilot AI commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

@Bryan-Roe Thanks for sending me some feedback. Unfortunately, I hit an error while trying to use the custom Copilot setup steps configured for this repository. The error I am seeing is:

no `copilot-setup-steps` job found in your `copilot-setup-steps.yml` workflow file. Please ensure you have a single job named `copilot-setup-steps`. For more details, see https://gh.io/copilot/actions-setup-steps

Once you or someone with the necessary access fixes the problem, please let me know in a comment and I'll try again. Thanks!

@Bryan-Roe Bryan-Roe removed their request for review July 5, 2026 19:06
@Bryan-Roe Bryan-Roe merged commit 9e1a21d into main Jul 5, 2026
36 of 41 checks passed
@Bryan-Roe Bryan-Roe deleted the chore/codeql-autofix-28751339070 branch July 5, 2026 19:07
@github-actions github-actions Bot added the tests label Jul 5, 2026
@github-actions github-actions Bot requested a review from Bryan-Roe July 5, 2026 19:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This is an automated style PR generated by the repository's CodeQL Advanced workflow, which runs ruff check --fix and ruff format. The changes are purely cosmetic: they reformat Python assert statements from the older condition-in-parentheses style (assert (\n cond\n), msg) to the Black-24+ message-in-parentheses style (assert cond, (\n msg\n)), and collapse one function signature onto a single line. No expressions, imports, logic, or test data are altered.

I verified that:

  • Every reformatted assertion is semantically identical — the parentheses wrap only the message expression (no tuple-assertion pitfall, no trailing commas that would create a truthy tuple).
  • The collapsed log_quantum_run_safe signature preserves the # noqa: ANN001 directive and its code portion fits the 120-char limit (the trailing comment does not trigger a split under Black/ruff-format).
  • Reformatted one-liner asserts stay within the 120-char limit (e.g., test_aria_server.py:175 is exactly 120), so ruff format and black --check agree and make lint remains green.
  • The transformation matches the established repo convention that the message-in-parens form is canonical for Black >= 24.

Changes:

  • Reformat assert statements across 9 test files to the message-in-parens style.
  • Collapse the log_quantum_run_safe signature in shared/db_logging.py to a single line.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/test_ui_playwright.py Reformats one assert message to parenthesized style.
tests/test_training_analytics_cli.py Reformats three return-code asserts.
tests/test_parallel_status.py Reformats one approx-comparison assert.
tests/test_orchestrator_health_integration.py Reformats one membership assert.
tests/test_consolidated_html.py Reformats several HTML/JS wiring asserts.
tests/test_aria_server.py Reformats many fallback-parser/tag asserts (largest set).
tests/test_aria_index_provider_wiring.py Reformats provider/model control asserts.
tests/test_aria_auto_execute_html.py Reformats one settings-persistence assert.
tests/test_agent_mode_delegation_contracts.py Reformats one alias-source assert.
shared/db_logging.py Collapses log_quantum_run_safe signature to one line.

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

🟡 Coverage — a4acc1b

Metric Value
Total coverage 66%
→ vs main 0.0%
Minimum threshold 60%

Updated on every push · 2026-07-05

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

🔐 CodeQL — Open Alerts on this PR

Severity Count
note 70
warning 13
high 5
error 9
medium 3

Copilot Autofix suggestions (if enabled) appear as inline review comments on the affected lines.
See the full list in the Security tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants