fix(e2e-tests): use pyppeteer bundled Chromium in containerized_chrome job#660
Conversation
…e job Debian Bullseye (python:3.11-bullseye container) does not provide chromium-browser in its APT repos. Replace the broken apt-get install fallback chain with pyppeteer's own bundled Chromium download (download_chromium()), matching the pattern already used in aria-tests.yml. Also removes the now-unnecessary CHROME_PATH=/usr/bin/chromium env var so pyppeteer finds its bundled binary automatically, and extends test_aria_tests_workflow.py to guard both workflows against future regressions.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @Copilot, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@Bryan-Roe Thanks for sending me some feedback. Unfortunately, I hit an error while trying to use the custom Copilot setup steps configured for this repository. The error I am seeing is: Once you or someone with the necessary access fixes the problem, please let me know in a comment and I'll try again. Thanks! |
There was a problem hiding this comment.
Pull request overview
This PR fixes a hard failure in the containerized_chrome (Pyppeteer) job of e2e-tests.yml. The job runs inside the python:3.11-bullseye image, where chromium-browser does not exist and chromium was dropped from the Bullseye apt repos, causing the apt fallback chain to fail. The fix replaces the brittle apt-install chain with Pyppeteer's bundled Chromium downloader, aligning the workflow with the already-working pattern in aria-tests.yml.
Changes:
- Replace the
apt-get install chromium / chromium-browserfallback chain withpyppeteer.chromium_downloader.download_chromium(), and drop the now-unnecessaryCHROME_PATH: /usr/bin/chromiumenv var (Pyppeteer auto-discovers its downloaded binary). - Extend the workflow guard test to assert
e2e-tests.ymlnever referenceschromium-browserorpython -m pyppeteer install, and always uses the bundleddownload_chromium()command.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/e2e-tests.yml |
Removes the broken apt Chromium install/normalize steps and CHROME_PATH, switching to Pyppeteer's bundled Chromium download to match aria-tests.yml. |
tests/test_aria_tests_workflow.py |
Factors the download command into a shared constant and adds a unit-marked guard asserting e2e-tests.yml uses the bundled downloader and avoids chromium-browser. |
Signed-off-by: Bryan <74067792+Bryan-Roe@users.noreply.github.com>
🔐 CodeQL — Open Alerts on this PR
Copilot Autofix suggestions (if enabled) appear as inline review comments on the affected lines. |
chromium-browserdoesn't exist on Debian Bullseye (thepython:3.11-bullseyecontainer image), andchromiumwas also dropped from Bullseye repos — causing the apt fallback chain to fail hard at step 5.Changes
e2e-tests.yml: Replace brokenapt-get install chromium / chromium-browserfallback chain with pyppeteer's bundled Chromium download, matching the pattern already used inaria-tests.yml:python -c "from pyppeteer.chromium_downloader import download_chromium; download_chromium()"Drop
CHROME_PATH: /usr/bin/chromium— pyppeteer auto-discovers its downloaded binary when the env var is absent.tests/test_aria_tests_workflow.py: Extend existing workflow guard to also asserte2e-tests.ymlnever containschromium-browserand always usesdownload_chromium().