Skip to content

Keep CodeQL c-cpp analysis buildless #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bryan-Roe merged 2 commits into from
Jul 11, 2026
+19 −5
Merged

Keep CodeQL c-cpp analysis buildless #838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5380db
Initial plan
Copilot Jul 11, 2026
7a1b0ef
fix: keep CodeQL c-cpp lane buildless
Copilot Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#
# Tuned for MAXIMUM security signal with INTEGRATED AUTOFIX:
# - All repo languages covered (Python, JS/TS, GitHub Actions; C/C++ via
# manual build when present). HTML is analyzed as part of
# buildless analysis). HTML is analyzed as part of
# javascript-typescript.
# - Query packs: security-extended + security-and-quality + experimental
# security queries, plus community security packs (when available).
Expand Down Expand Up @@ -118,7 +118,7 @@ jobs:
os: ubuntu-latest

- language: c-cpp
build-mode: autobuild
build-mode: none
os: ubuntu-latest
timeout-minutes: 360
timeout-minutes: 360
Expand Down
20 changes: 17 additions & 3 deletions tests/test_codeql_workflow_paths_ignore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,20 @@ def test_codeql_workflow_ignores_issue_template_changes() -> None:
assert ".github/ISSUE_TEMPLATE/**" in workflow["on"]["pull_request"]["paths-ignore"]


@pytest.mark.unit
def test_codeql_c_cpp_uses_buildless_mode() -> None:
workflow_path = Path(__file__).resolve().parents[1] / ".github" / "workflows" / "codeql.yml"
workflow = yaml.load(workflow_path.read_text(encoding="utf-8"), Loader=yaml.BaseLoader)

c_cpp_entry = next(
entry for entry in workflow["jobs"]["analyze"]["strategy"]["matrix"]["include"] if entry["language"] == "c-cpp"
)

assert (
c_cpp_entry["build-mode"] == "none"
), "The c-cpp CodeQL lane must stay buildless so it does not invoke the repo root Makefile via autobuild."
Comment on lines +26 to +32


@pytest.mark.unit
def test_codeql_autofix_ref_step_avoids_unbound_shell_vars() -> None:
workflow_path = Path(__file__).resolve().parents[1] / ".github" / "workflows" / "codeql.yml"
Expand Down Expand Up @@ -101,6 +115,6 @@ def test_codeql_config_has_document_start_and_no_trailing_whitespace() -> None:
content = config_path.read_text(encoding="utf-8")

assert content.startswith("---\n"), "CodeQL config must keep its YAML document start marker."
assert all(line == line.rstrip() for line in content.splitlines()), (
"CodeQL config should not contain trailing whitespace."
)
assert all(
line == line.rstrip() for line in content.splitlines()
), "CodeQL config should not contain trailing whitespace."
Loading