Skip to content

fix: add regression test guarding devcontainer-lock.json JSON validity#856

Merged
Bryan-Roe merged 2 commits into
mainfrom
copilot/fix-build-and-test-job
Jul 11, 2026
Merged

fix: add regression test guarding devcontainer-lock.json JSON validity#856
Bryan-Roe merged 2 commits into
mainfrom
copilot/fix-build-and-test-job

Conversation

Copilot AI commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

The build-and-test devcontainer CI job was failing because a stray } was appended to .devcontainer/devcontainer-lock.json, making it invalid JSON. The devcontainers CLI aborted immediately with SyntaxError: Unexpected non-whitespace character after JSON at position 2143 (line 35 column 3) — before even attempting to build or run tests.

Changes

  • Structural fix (PR fix: remove stray closing brace corrupting devcontainer-lock.json #852, already merged): Removed the stray closing brace from devcontainer-lock.json.
  • Regression test (tests/unit/test_devcontainer_json.py): Three unit tests that validate both .devcontainer/devcontainer.json and devcontainer-lock.json parse as valid JSON and that the lock file has the expected top-level features key. These run in the fast unit suite (python scripts/test_runner.py --unit) and will catch this class of corruption before it reaches CI.

Copilot AI requested review from Copilot and removed request for Copilot July 11, 2026 04:43

Copilot AI commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

@Bryan-Roe Unfortunately, I hit an error while trying to use the custom Copilot setup steps configured for this repository and had to close this PR. The error I am seeing is:

no `copilot-setup-steps` job found in your `copilot-setup-steps.yml` workflow file. Please ensure you have a single job named `copilot-setup-steps`. For more details, see https://gh.io/copilot/actions-setup-steps

Once you or someone with the necessary access fixes the problem, please unassign and then reassign issue #0 to me and I'll retry. Thanks!

Copilot AI requested review from Copilot and removed request for Copilot July 11, 2026 04:49
Copilot AI changed the title [WIP] Fix failing GitHub Actions job build-and-test fix: add regression test guarding devcontainer-lock.json JSON validity Jul 11, 2026
Copilot AI requested a review from Bryan-Roe July 11, 2026 04:49
@Bryan-Roe Bryan-Roe marked this pull request as ready for review July 11, 2026 05:41
Copilot AI review requested due to automatic review settings July 11, 2026 05:41
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@Bryan-Roe Bryan-Roe merged commit c5b9400 into main Jul 11, 2026
5 of 10 checks passed

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Bryan-Roe, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

Copilot AI commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

@Bryan-Roe Thanks for sending me some feedback. Unfortunately, I hit an error while trying to use the custom Copilot setup steps configured for this repository. The error I am seeing is:

no `copilot-setup-steps` job found in your `copilot-setup-steps.yml` workflow file. Please ensure you have a single job named `copilot-setup-steps`. For more details, see https://gh.io/copilot/actions-setup-steps

Once you or someone with the necessary access fixes the problem, please let me know in a comment and I'll try again. Thanks!

@Bryan-Roe Bryan-Roe deleted the copilot/fix-build-and-test-job branch July 11, 2026 05:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds regression coverage preventing malformed devcontainer JSON from reaching CI.

Changes:

  • Validates both devcontainer JSON files parse successfully.
  • Verifies the lock file contains its required features key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants