fix: add regression test guarding devcontainer-lock.json JSON validity#856
Conversation
|
@Bryan-Roe Unfortunately, I hit an error while trying to use the custom Copilot setup steps configured for this repository and had to close this PR. The error I am seeing is: Once you or someone with the necessary access fixes the problem, please unassign and then reassign issue #0 to me and I'll retry. Thanks! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Sorry @Bryan-Roe, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
@Bryan-Roe Thanks for sending me some feedback. Unfortunately, I hit an error while trying to use the custom Copilot setup steps configured for this repository. The error I am seeing is: Once you or someone with the necessary access fixes the problem, please let me know in a comment and I'll try again. Thanks! |
The
build-and-testdevcontainer CI job was failing because a stray}was appended to.devcontainer/devcontainer-lock.json, making it invalid JSON. The devcontainers CLI aborted immediately withSyntaxError: Unexpected non-whitespace character after JSON at position 2143 (line 35 column 3)— before even attempting to build or run tests.Changes
devcontainer-lock.json.tests/unit/test_devcontainer_json.py): Three unit tests that validate both.devcontainer/devcontainer.jsonanddevcontainer-lock.jsonparse as valid JSON and that the lock file has the expected top-levelfeatureskey. These run in the fast unit suite (python scripts/test_runner.py --unit) and will catch this class of corruption before it reaches CI.