-
-
Notifications
You must be signed in to change notification settings - Fork 2
Fix test collection crashes when optional dependencies are absent #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
c10710d
eba106c
85e3a82
e0bee47
4061755
480b155
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| {"messages": [{"role": "user", "content": "What is a matrix strategy in GitHub Actions?"}, {"role": "assistant", "content": "A matrix strategy in GitHub Actions allows you to run a job with multiple configurations automatically:\n\n```yaml\njobs:\n test:\n runs-on: ubuntu-latest\n strategy:\n matrix:\n python-version: ['3.9', '3.10', '3.11', '3.12']\n os: [ubuntu-latest, windows-latest, macos-latest]\n steps:\n - uses: actions/setup-python@v5\n with:\n python-version: ${{ matrix.python-version }}\n - run: python --version\n - run: pytest\n```\n\nThis creates 12 jobs (4 Python versions × 3 OS) automatically.\n\n**Key features**:\n- `${{ matrix.variable }}` accesses matrix values\n- `fail-fast: false` continues other jobs if one fails\n- `max-parallel` limits concurrent jobs\n- `include` adds specific combinations\n- `exclude` removes specific combinations\n\n**Use cases**:\n- Testing across multiple Python/Node versions\n- Cross-platform testing (Linux, Windows, macOS)\n- Testing with different dependency versions\n- Different configuration combinations"}], "source": "general_knowledge", "template": "matrix"} | ||
| {"messages": [{"role": "user", "content": "What jobs are defined in the 'Auto Validation' workflow?"}, {"role": "assistant", "content": "The workflow defines 1 job(s):\n\n\n**dry-run**:\n - Runs on: ubuntu-latest\n - Contains 5 step(s)"}], "source_workflow": "Auto Validation", "source_path": ".github/workflows/auto-validation.yml", "template": "jobs", "hash": "510dd0820fe98f3b"} | ||
| {"messages": [{"role": "user", "content": "When does the 'Aria E2E Tests' workflow run?"}, {"role": "assistant", "content": "This workflow has no explicit triggers defined."}], "source_workflow": "Aria E2E Tests", "source_path": ".github/workflows/aria-tests.yml", "template": "triggers", "hash": "0b108737ae091f7e"} | ||
| {"messages": [{"role": "user", "content": "What jobs are defined in the 'Workflow Validation' workflow?"}, {"role": "assistant", "content": "The workflow defines 2 job(s):\n\n\n**validate-workflows**:\n - Runs on: ubuntu-latest\n - Contains 5 step(s)\n\n**test-workflows**:\n - Runs on: ubuntu-latest\n - Depends on: validate-workflows\n - Contains 3 step(s)"}], "source_workflow": "Workflow Validation", "source_path": ".github/workflows/workflow-validation.yml", "template": "jobs", "hash": "cb9797af5c503cf7"} | ||
| {"messages": [{"role": "user", "content": "When does the 'QAI CI Pipeline' workflow run?"}, {"role": "assistant", "content": "This workflow has no explicit triggers defined."}], "source_workflow": "QAI CI Pipeline", "source_path": ".github/workflows/ci-pipeline.yml", "template": "triggers", "hash": "021d60314cdee68f"} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Useful? React with 👍 / 👎. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This new held-out sample says the workflow has no triggers, but Useful? React with 👍 / 👎. |
||
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,8 @@ | |
|
|
||
| from pathlib import Path | ||
|
|
||
| pytest.importorskip("playwright", reason="playwright is not installed") | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Both Useful? React with 👍 / 👎. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I checked Useful? React with 👍 / 👎. |
||
|
|
||
| REPO_ROOT = Path(__file__).resolve().parents[1] | ||
| ARIA_WEB = REPO_ROOT / 'aria_web' | ||
| SERVER_URL = 'http://127.0.0.1:8080' | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR modifies an existing file under
datasets/, but the repo’s documented convention is thatdatasets/is read-only/immutable. Please revert these dataset edits (or add new data as a new versioned dataset directory or underdata_out/and update the relevant training config to point at it).