Update to 1.20.4 (Must be tested before merging)#65
Update to 1.20.4 (Must be tested before merging)#65TechPro424 wants to merge 11 commits intoBstn1802:masterfrom
Conversation
Needs to be tested The method signature for the IntegratedServerLoader.start() method was changed in either 1.20.3 or 1.20.4 It now needs a runnable as the 2nd parameter (parameter name is onCancel) So as of now the onCancel runnable is just a lambda function as I am not sure what the runnable should do (maybe return the player to the title screen?) The runnable seems to be run whenever an exception is encountered while running the start() method and the world cannot be "recovered" (not too sure what that means)
needs to be tested The RealmsGetServerDetailsTask seems to have been removed in either 1.20.3 or 1.20.4 The 2 Tasks that seemed to fit the most were OpenServerTask and RealmsPrepareConnectionTask I looked into the OpenServerTask, and saw that if the boolean join was true, it would execute a play method in the RealmsMainScreen class that in turn runs the RealmsPrepareConnectionTask Hence I decided to use the OpenServerTask for now
By fixing an inject to the startIntegratedServer method The method signature had changed
|
you can just check what the game does, there are 2 linked functions in the jdoc comments ( |
… player to the title screen Just found out that the onCancel lambda sends the player to the title screen, so made the mod replicate that Thanks to itsTyrion on GitHub for pointing that out! (See Bstn1802#65 (comment))
Thanks for pointing that out! Since there are 2 PRs, do you want me to close mine or are you ok with closing yours? (Also I think you meant startSingleplayer there instead of startRealms) |
…, replicating the vanilla game Also removed the comments warning about the untested changes
|
Also fixed the reconnectMethod override in RealmsReconnectStrategy |
2 participants
Updates the mod to 1.20.4