draft/miner#86
Open
vienlnn wants to merge 24 commits into
Open
Conversation
…nt checkpoint validation time out
imduchuyyy
suggested changes
May 11, 2026
Comment on lines
+718
to
+732
| select { | ||
| case <-abort: | ||
| return | ||
| case <-timeout: | ||
| // Avoid deadlock during sync: if we can't get state in time, | ||
| // skip the state-dependent checkpoint validation. | ||
| log.Warn("VerifyHeaders: timeout waiting for gap block state, skipping checkpoint state validation", | ||
| "checkpoint", number, "requiredBlock", requiredBlock, | ||
| "currentBlock", cb.NumberU64()) | ||
| waited = true | ||
| case <-time.After(200 * time.Millisecond): | ||
| } | ||
| if waited { | ||
| break | ||
| } |
imduchuyyy
suggested changes
May 11, 2026
| // | ||
| // This is the single entry point for both the miner and block import to apply | ||
| // a transaction under POSV consensus, ensuring identical state transitions. | ||
| func ApplyTransactionPosv(config *params.ChainConfig, bc ChainContext, author *common.Address, gp *GasPool, statedb *state.StateDB, header *types.Header, tx *types.Transaction, usedGas *uint64, cfg vm.Config) (*types.Receipt, error) { |
Contributor
There was a problem hiding this comment.
why you don't use the origin ApplyTransaction
imduchuyyy
suggested changes
May 11, 2026
Comment on lines
-432
to
+450
|
|
||
| log := &types.Log{} | ||
| log.Address = p.config.Viction.ValidatorBlockSignContract | ||
| log.BlockNumber = header.Number.Uint64() | ||
| statedb.AddLog(log) | ||
| // Set the receipt logs and create a bloom for filtering | ||
| logEntry := &types.Log{} | ||
| logEntry.Address = config.Viction.ValidatorBlockSignContract | ||
| logEntry.BlockNumber = header.Number.Uint64() | ||
| statedb.AddLog(logEntry) |
Contributor
There was a problem hiding this comment.
What are you doing here?
Contributor
|
Please clean the PR, all the new code ralated to Victionchain, create a separate file for it. |
Contributor
|
We just added new params on viction config for finalized api, this PR introduced new network profile, make sure you have add it to your config. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.