Implement eip-1186, eth_getProof#474
Open
khangnt-coin98 wants to merge 2 commits into
Open
Conversation
imterryyy
reviewed
Nov 5, 2024
Collaborator
|
Please resolve conflict |
Author
resolved |
Author
|
@imterryyy should we also implement blockhash support for this method? |
Collaborator
|
yes, why not. |
Author
this may result in many changes, and conflict to other apis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#473
References:
Flowchart summary:
General
Notice:
Pending block tag support, when client call method, miner returns block with falsy value (block number 0x1400224ca20). Latest version of Geth should prevent calling with a “pending” block tag.