Fix override state when UpdateTRC21Fee#526
Open
vienlnn wants to merge 20 commits into
Open
Conversation
imduchuyyy
reviewed
Jun 2, 2025
|
|
||
| func UpdateTRC21Fee(statedb *StateDB, newBalance map[common.Address]*big.Int, totalFeeUsed *big.Int) { | ||
| if statedb == nil || len(newBalance) == 0 { | ||
| func UpdateTRC21Fee(statedb *StateDB, usedBalance map[common.Address]*big.Int, totalFeeUsed *big.Int) { |
Contributor
There was a problem hiding this comment.
can we calculate totalFeeUsed inside of UpdateTRC21Fee function
imduchuyyy
approved these changes
Jun 4, 2025
Collaborator
|
At the current state, the PR will break the chain. It needs a hard fork to separate the logic before the fix and after the fix. |
Contributor
|
Is this identical to the pull request at #530? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.