Fix Viction always warning when a peer disconnected#537
Open
c98tristan wants to merge 6 commits into
Open
Conversation
…g-optional Make mine flag and etherbase optional
… at the same time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a peer is disconnected, others peer will always log warning:
Because of the
pairPeerconnection. When a peer is connected, another connection calledpairPeerwill be established. It's help split the data transfer through into one for Transactions, Announcements and one for Blocks, Headers, Bodies.But when the peer is disconnected, 2 connections will simultaneously unregister the same peer and cause the race condition.
Solution
Introduce a
unregisterMutexto synchronize unregister peer to prevent race condition.Additional