Skip to content

Fix configurable visual recap runner shell #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steve8708 merged 2 commits into from
Jul 20, 2026
Merged

Fix configurable visual recap runner shell #2097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f3c091
fix: run configurable visual recaps with bash
CheckPickerUpper Jul 13, 2026
cbd7956
Merge branch 'main' into feat/self-hosted-visual-recap
steve8708 Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/friendly-runners-use-bash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@agent-native/core": patch
"@agent-native/recap-cli": patch
---

Run configurable PR Visual Recap jobs with Bash on every runner platform.
3 changes: 3 additions & 0 deletions .github/workflows/pr-visual-recap-reusable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,9 @@ jobs:
if: needs.gate.outputs.run == 'true'
runs-on: ${{ fromJSON(needs.gate.outputs.runs_on) }}
timeout-minutes: 30
defaults:
run:
shell: bash
permissions:
actions: write
checks: write
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/pr-visual-recap.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,9 @@ jobs:
if: needs.gate.outputs.run == 'true'
runs-on: ${{ fromJSON(needs.gate.outputs.runs_on) }}
timeout-minutes: 30
defaults:
run:
shell: bash
permissions:
actions: write
checks: write
Expand Down
5 changes: 3 additions & 2 deletions packages/core/src/cli/pr-visual-recap-workflow.ts
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions packages/core/src/cli/recap.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3043,6 +3043,9 @@ describe("bundled PR visual recap workflow", () => {
expect(PR_VISUAL_RECAP_WORKFLOW_YML).toContain(
"runs-on: ${{ fromJSON(needs.gate.outputs.runs_on) }}",
);
expect(PR_VISUAL_RECAP_WORKFLOW_YML).toContain(
" defaults:\n run:\n shell: bash",
);
expect(PR_VISUAL_RECAP_WORKFLOW_YML).toContain(
"core.setOutput('runs_on', JSON.stringify(configuredRunner))",
);
Expand Down Expand Up @@ -3617,6 +3620,7 @@ describe("reusable workflow file structure", () => {
expect(content).toContain(
"runs-on: ${{ fromJSON(needs.gate.outputs.runs_on) }}",
);
expect(content).toContain(" defaults:\n run:\n shell: bash");
expect(content).toContain(
"core.setOutput('runs_on', JSON.stringify(configuredRunner))",
);
Expand Down
29 changes: 29 additions & 0 deletions packages/recap-cli/src/pr-visual-recap-workflow.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import { readFileSync } from "node:fs";
import path from "node:path";
import { fileURLToPath } from "node:url";

import { describe, expect, it } from "vitest";

import { PR_VISUAL_RECAP_WORKFLOW_YML } from "./pr-visual-recap-workflow.js";

const repoRoot = path.resolve(
path.dirname(fileURLToPath(import.meta.url)),
"../../..",
);

describe("the recap installer workflow", () => {
it("keeps Bash semantics on configurable runners", () => {
expect(PR_VISUAL_RECAP_WORKFLOW_YML).toContain(

@builder-io-integration builder-io-integration Bot Jul 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Recap CLI bundle is missing the Bash shell fix

The new regression assertion fails because the bundled installer string does not contain the canonical defaults.run.shell: bash block. Users installing through @agent-native/recap-cli can still execute Bash-syntax steps under PowerShell on Windows or another default shell on configurable runners; regenerate the bundle from the canonical workflow.

Fix in Builder

" defaults:\n run:\n shell: bash",
);
});

it("bundles the canonical workflow byte for byte", () => {
const source = readFileSync(
path.join(repoRoot, ".github/workflows/pr-visual-recap.yml"),
"utf8",
);

expect(PR_VISUAL_RECAP_WORKFLOW_YML).toBe(source);
});
});
Loading