Fix Slack continuation replies and Content provenance#2223
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Here's a visual recap of what changed: Open the full interactive recap |
40451be to
d79a770
Compare
There was a problem hiding this comment.
Builder reviewed your changes — looks good ✅
Review Details
Incremental Code Review Summary
The latest commit fixes the prior audience-binding issue by requiring __a2aAudienceVerified === true before resolving any opaque Slack integration reference. The new regression test covers a verified-but-audience-unbound token, and the stale blocking review thread has been resolved.
The current design now combines audience-bound A2A authentication with an opaque task reference, Dispatch-side owner/email and organization scoping, validated Slack URL extraction, and fail-closed resolver behavior. Async propagation, continuation delivery, artifact guarding, and the earlier parent-mutation preservation fix remain intact. Two parallel balanced reviews found no new confirmed bugs, security issues, or performance regressions.
Risk level: High, because the PR changes authenticated cross-app metadata and persisted provenance.
🧪 Browser testing: Skipped — the incremental changes are limited to backend/core and Dispatch integration logic, tests, and documentation; there is no browser UI impact.

Summary
Verification
Human QA
The real successful-user story requires the production Slack bot; there is no preview Slack environment. After merge and clean deployment, run the frozen story:
No production mutation or live Slack reproduction was run in this PR.