feat(clips): add local Rewind memory and semantic chapters#2251
Conversation
This comment has been minimized.
This comment has been minimized.
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 34948924 | Triggered | Bearer Token | 956e95c | packages/core/src/mcp/screen-memory-stdio.spec.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Here's a visual recap of what changed: Open the full interactive recap
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Landing verification update:
No merge performed; maintainer approval is still required.
|
There was a problem hiding this comment.
Builder reviewed your changes and found 1 potential issue 🔴
Review Details
Code Review Summary
This incremental review covers the latest Rewind changes, including durable recording boundaries, portable OCR helper builds, localization, and the new privacy/share safeguards. The three findings from the prior review were rechecked and are fixed: stored private-window exclusions are preserved, tainted/unretained rows are filtered from MCP context, and the Rewind privacy transition now uses a conditional update. Those review threads were resolved.
The remaining implementation is generally well-structured, with explicit local-only boundaries, bounded MCP egress, atomic privacy transition semantics, and focused desktop/UI coverage. However, this remains a high-risk change because screen and audio evidence can contain sensitive user data.
Key Findings
- 🔴 HIGH — Screen Memory exclusion settings are parsed and persisted in the local MCP client, but context retrieval does not apply
excludedBundleIdsorexcludePrivateWindows. If a store contains rows produced before native filtering, or is accessed through a standalone/local MCP configuration, explicitly excluded sensitive-app or private-window evidence can still be returned to the agent.
🧪 Browser testing: Will run after this review (PR touches UI code)
This comment has been minimized.
This comment has been minimized.
|
Landing addendum (Codex): final head |

Summary
mainrecording finalization, pending-upload recovery, deep-link behavior, and native/browser recorder safeguardsProduct and privacy contract
Semantic chapters
Verification
git diff --checkpassed75fa94905, including a cross-session retained preview whose QuickTime artifact matched the exact request ID, decline with no upload, and terminal reason scrubbingKnown release boundaries
clips.agent-native.comround trip remains a post-deployment acceptance storyGoverning brief
Architecture fingerprint:
rewind-semantic-chapters-r5