Skip to content

feat(plugin-tools): ENG-12227 add remove button to ResourcesPickerButton #4510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Manish-Builder-io wants to merge 3 commits into
base: main
Choose a base branch
from
+23 −3
Open

feat(plugin-tools): ENG-12227 add remove button to ResourcesPickerButton #4510

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d02a45
feat(plugin-tools): add remove button to ResourcesPickerButton
Manish-Builder-io Apr 13, 2026
0191646
update the onChange value
sanyamkamat Apr 17, 2026
69d563c
Merge branch 'main' into feat/plugin-tools-remove-resource-button
sanyamkamat Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions packages/plugin-tools/src/editors/ResourcesPicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
TextField,
Typography,
} from '@material-ui/core';
import { Create, Search } from '@material-ui/icons';
import { Close, Create, Search } from '@material-ui/icons';
import { runInAction, action } from 'mobx';
import { useObserver, useLocalStore } from 'mobx-react';
import React, { useEffect } from 'react';
Expand Down Expand Up @@ -304,11 +304,11 @@ export const ResourcesPickerButton: React.FC<ResourcesPickerButtonProps> = props
position: 'relative',
}}
>
<ResourcePreviewCell button css={{ paddingRight: 30 }} resource={store.resourceInfo} />
<ResourcePreviewCell button css={{ paddingRight: 70 }} resource={store.resourceInfo} />
<IconButton
css={{
position: 'absolute',
right: 2,
right: 42,
top: 0,
bottom: 0,
height: 50,
Expand All @@ -321,6 +321,26 @@ export const ResourcesPickerButton: React.FC<ResourcesPickerButtonProps> = props
>
<Create css={{ color: '#888' }} />
</IconButton>
<IconButton
css={{
position: 'absolute',
right: 2,
top: 0,
bottom: 0,
height: 50,
marginTop: 'auto',
marginBottom: 'auto',
opacity: 0.7,
}}
onClick={action(() => {
store.resourceHandle = undefined;
store.resourceId = undefined;
store.resourceInfo = null;
props.onChange(undefined);
})}
>
<Close css={{ color: '#888' }} />
</IconButton>
</Paper>
)}
{!store.resourceInfo && !store.loading && (
Expand Down
Loading