This repository was archived by the owner on Aug 6, 2018. It is now read-only.
Small fixes to lights - grammar & transitiontime#7
Open
peterkaminski wants to merge 4 commits intoBurgestrand:masterfrom
Open
Small fixes to lights - grammar & transitiontime#7peterkaminski wants to merge 4 commits intoBurgestrand:masterfrom
peterkaminski wants to merge 4 commits intoBurgestrand:masterfrom
Conversation
grammar fix, it's -> its
Testing with my Philips Hue system shows transitiontime to be in deciseconds, not centiseconds. Bridge = Philips BSB001, swversion = 01024156. Lights are Philips LWB004 (Hue Lux) swversion = 66012040.
update transitiontime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes to the lights file: a grammar fix (it's -> its), and a change for "transitiontime" to reflect testing on my Hue system -- at least for me, transitiontime is in deciseconds rather than centiseconds.
Thanks for this project, btw -- it's clear and helpful.